-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OSPO Book] Update 05-chapter.md - OSPO Metrics with CHAOSS #516
Conversation
This is the first PR for Chapter 5 content. Signed-off-by: Matt Germonprez <[email protected]>
✅ Deploy Preview for ospomindmap canceled.
|
✅ Deploy Preview for ospobook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Thank you @germonprez ! I will allocate some time during our two contributor's call agenda next Monday to let people go through the content and review together PS: AFAIK, I remember there were some visuals included in the google doc version. would it be possible to add it to the PR to? |
Yes. I can add the one visual. Where do you want images placed? Is there a central folder for chapter images? |
Yes! all images should be stored here: https://github.com/todogroup/ospology/tree/main/ospo-book/static/images P.S. I still need to clean up the folders to move the images displayed in the book to the correct folder |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, well written chapter!
Fixing some typos and grammar issues. Signed-off-by: Matt Germonprez <[email protected]>
Pushing a few changes: 1. Including links to CHAOSS Practitioner Guides 2. Including Impact Image 3. Rearranging Impact 2 & 3 to align with the Impact Image in point 2. Signed-off-by: Matt Germonprez <[email protected]>
I have updated the PR to include the things discussed in our book meeting today. Specifically:
|
ospo-book/content/en/05-chapter.md
Outdated
|
||
### Communicating Impact: Open Source | ||
|
||
Beyond helping understand one open source project or a collection of projects, metrics can also play an important role in communicating impact. Finding consistent and meaningful ways to communicate impact is important for any organization unit, including open source program offices. Following approaches used in the CHAOSS project, we present four goals that open source program offices can consider concerning open source project engagement. Stemming from these goals, we recommend a series of metric-related considerations that could prove pertinent to specific organizational concerns. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a duplicate of the paragraph above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have reworked these two paragraphs. Basically just removing the duplicate text from one of them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I note that the chapter name is now different, it may be worth harmonizing it with the TOC so they align. https://ospobook.todogroup.org/toc/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No problem
Signed-off-by: Matt Germonprez <[email protected]> Co-authored-by: Alice Sowerby <[email protected]> Signed-off-by: Matt Germonprez <[email protected]>
Signed-off-by: Matt Germonprez <[email protected]> Co-authored-by: Alice Sowerby <[email protected]> Signed-off-by: Matt Germonprez <[email protected]>
Signed-off-by: Matt Germonprez <[email protected]> Co-authored-by: Alice Sowerby <[email protected]> Signed-off-by: Matt Germonprez <[email protected]>
Signed-off-by: Matt Germonprez <[email protected]> Co-authored-by: Alice Sowerby <[email protected]> Signed-off-by: Matt Germonprez <[email protected]>
Signed-off-by: Matt Germonprez <[email protected]> Co-authored-by: Alice Sowerby <[email protected]> Signed-off-by: Matt Germonprez <[email protected]>
Signed-off-by: Matt Germonprez <[email protected]> Co-authored-by: Alice Sowerby <[email protected]> Signed-off-by: Matt Germonprez <[email protected]>
Updating to remove some duplicate text. Signed-off-by: Matt Germonprez <[email protected]>
@alice-sowerby is this PR ready for merge? please note that early next year (probably January or mid February) , there will be a review meeting to go through all chapters at once for final review and cross-referencing |
@anajsana I have put some time in my calendar for this Friday to catch up on the book stuff! Will respond more fully then. |
Sorry for the delay, I’ve been unwell. Will get to this soon.
Sent from Outlook for iOS<https://aka.ms/o0ukef>
…________________________________
From: Ana Jimenez Santamaria ***@***.***>
Sent: Wednesday, December 18, 2024 4:06:28 PM
To: todogroup/ospology ***@***.***>
Cc: Alice Sowerby ***@***.***>; Mention ***@***.***>
Subject: Re: [todogroup/ospology] [OSPO Book] Update 05-chapter.md - OSPO Metrics with CHAOSS (PR #516)
@alice-sowerby<https://github.com/alice-sowerby> is this PR ready for merge? please note that early next year (probably January or mid February) , there will be a review meeting to go through all chapters at once for final review and cross-referencing
—
Reply to this email directly, view it on GitHub<#516 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AEHGYSF3QLJNZ45AGBAP4FT2GGMQJAVCNFSM6AAAAABRLNXLUSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNJRG4YTSNRWGI>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Looks good to me (but I cannot build locally to double check the formatting). |
@anajsana I can do the rebase & merge if you want me to. Unclear as to whether you prefer to do it. |
Rebase and merge will work. If you are unable to make the merge this way, I can do it for you 😊 @alice-sowerby |
This is the first PR for Chapter 5 content.
Watch the preview here